hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7118) Improve diagnostics on storage directory rename operations by using NativeIO#renameTo in Storage#rename.
Date Fri, 26 Sep 2014 11:35:36 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14149043#comment-14149043
] 

Hudson commented on HDFS-7118:
------------------------------

FAILURE: Integrated in Hadoop-Yarn-trunk #692 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/692/])
HDFS-7118. Improve diagnostics on storage directory rename operations by using NativeIO#renameTo
in Storage#rename. Contributed by Chris Nauroth. (cnauroth: rev e0b1dc514f1b9e26b21d97ece0d94cd9c827fc59)
* hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileJournalManager.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/Storage.java


> Improve diagnostics on storage directory rename operations by using NativeIO#renameTo
in Storage#rename.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-7118
>                 URL: https://issues.apache.org/jira/browse/HDFS-7118
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: journal-node, namenode
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>             Fix For: 2.6.0
>
>         Attachments: HDFS-7118.1.patch
>
>
> If a file rename fails, {{NativeIO#renameTo}} includes more information about the root
cause than a plain {{java.io.File#renameTo}}.  The native code can throw an exception with
a detailed error message and the {{errno}} on *nix or the value of {{GetLastError}} on Windows.
 This issue proposes to use {{NativeIO#renameTo}} inside or in place of {{Storage#rename}}
to help improve diagnostics.  The method falls back to {{java.io.File#renameTo}} if native
code is not loaded, so this change would not introduce a compatibility problem for deployments
running without native code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message