hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7072) Fix TestBlockManager#testUseDelHint
Date Tue, 16 Sep 2014 19:07:35 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135988#comment-14135988
] 

Jing Zhao commented on HDFS-7072:
---------------------------------

In HDFS-7034, we changed {{BlockManager#useDelHint}} to call {{excessTypes.contains}} instead
of {{excessTypes.remove}}. This causes inconsistency with {{TestBlockManager#testUseDelHint}}.

In the meanwhile, {{TestStorageMover#testNoSpaceDisk}} and {{TestStorageMover#testNoSpaceArchive}}
still failed in https://builds.apache.org/job/PreCommit-HDFS-Build/8031//testReport/. Looks
like the tests failed when we tried to write the first file in order to use all the DISK/ARCHIVE
space. I cannot reproduce this failure in my local machine. But looking into the code, the
cause may be that after {{DatanodeStorageInfo#remaining}} got updated from the heartbeat,
the {{BlockPlacementPolicyDefault#isGoodTarget}} failed to read its latest value. Thus we
should declare remaining as volatile.

> Fix TestBlockManager#testUseDelHint
> -----------------------------------
>
>                 Key: HDFS-7072
>                 URL: https://issues.apache.org/jira/browse/HDFS-7072
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: balancer, namenode
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message