hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7010) boot up libhdfs3 project
Date Mon, 08 Sep 2014 21:37:29 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126149#comment-14126149
] 

Colin Patrick McCabe commented on HDFS-7010:
--------------------------------------------

All .h and .cc files should begin with this header:

{code}
/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
 * to you under the Apache License, Version 2.0 (the
 * "License"); you may not use this file except in compliance
 * with the License.  You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
{code}

We even include this at the top of CMakeLists.txt files, etc.
There isn't a need for a LICENSE.txt in this directory either.

{code}
Dependencies:
+    c/c++ compiler
{code}
Should be just "c++ compiler"

{code}
+To build libhdfs3, the following libraries are needed.
+
+    cmake (2.8+)                    http://www.cmake.org/
+    boost (tested on 1.53+)         http://www.boost.org/
{code}

boost isn't needed, so let's get rid of that in the "needed" section.

Maybe doxygen should be mentioned somewhere in the README?

Also please convert the readmes to .apt.vm, not .md.  It's described here: http://maven.apache.org/doxia/references/apt-format.html
 It's probably helpful to look at an example document like {{hadoop-hdfs-project/hadoop-hdfs/src/site/apt/LibHdfs.apt.vm}}

{code}
TARGET_LINK_LIBRARIES(function ${LIBXML2_LIBRARIES})
{code}

Should be expat

{code}
AUTO_SOURCES(secure_SOURCES "*.cpp" "RECURSE" "${CMAKE_CURRENT_SOURCE_DIR}")
{code}

We use .cc, not .cpp

Thanks.

> boot up libhdfs3 project
> ------------------------
>
>                 Key: HDFS-7010
>                 URL: https://issues.apache.org/jira/browse/HDFS-7010
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Zhanwei Wang
>         Attachments: HDFS-7010.patch
>
>
> boot up libhdfs3 project with CMake, Readme and license file.
> Integrate google mock and google test



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message