hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6984) In Hadoop 3, make FileStatus no longer a Writable
Date Fri, 05 Sep 2014 19:05:29 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14123402#comment-14123402
] 

Colin Patrick McCabe commented on HDFS-6984:
--------------------------------------------

So, it looks like DistCp depends on {{FileStatus}} being writable in a pretty fundamental
way, since it wants to use it as a MapReduce value in CopyMapper.java:

{code}
public class CopyMapper extends Mapper<Text, CopyListingFileStatus, Text, Text> {
...
{code}

Maybe, rather than get rid of the "implements Writable", we should just use protobuf for the
serialization in {{FileStatus#write}}.  That allows us to add whatever fields we want later
via optional protobuf members.

> In Hadoop 3, make FileStatus no longer a Writable
> -------------------------------------------------
>
>                 Key: HDFS-6984
>                 URL: https://issues.apache.org/jira/browse/HDFS-6984
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-6984.001.patch
>
>
> FileStatus was a Writable in Hadoop 2 and earlier.  Originally, we used this to serialize
it and send it over the wire.  But in Hadoop 2 and later, we have the protobuf {{HdfsFileStatusProto}}
which serves to serialize this information.  The protobuf form is preferable, since it allows
us to add new fields in a backwards-compatible way.  Another issue is that already a lot of
subclasses of FileStatus don't override the Writable methods of the superclass, breaking the
interface contract that read(status.write) should be equal to the original status.
> In Hadoop 3, we should just make FileStatus no longer a writable so that we don't have
to deal with these issues.  It's probably too late to do this in Hadoop 2, since user code
may be relying on the ability to use the Writable methods on FileStatus objects there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message