hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Charles Lamb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6970) Move startFile EDEK retries to the DFSClient
Date Thu, 18 Sep 2014 19:06:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14139346#comment-14139346
] 

Charles Lamb commented on HDFS-6970:
------------------------------------

LGTM. Nits only.

DFSOutputStream.java

newStreamForCreate, buffersize arg is no longer used so perhaps mark it as such either with
a comment or by renaming to your favorite version of "ignore".

FSNamesystem.java

Seems like there was some whitespace introduced.

RetryStartFileException

IntelliJ says the second ctor is unused. Is it there for posterity?

TestEncryptionZones#testStartFileRetry - at first blush this seems to fix the timeout problems
we've been seeing.


> Move startFile EDEK retries to the DFSClient
> --------------------------------------------
>
>                 Key: HDFS-6970
>                 URL: https://issues.apache.org/jira/browse/HDFS-6970
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: encryption
>    Affects Versions: 2.5.0
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-6970.001.patch
>
>
> [~sureshms] pointed out that holding on to an RPC handler while talking to the KMS is
bad, since it can exhaust the available handlers. Let's avoid this by doing retries at the
DFSClient rather than in the RPC handler, and moving EDEK fetching to the background.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message