hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Megasthenis Asteris (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6799) The invalidate method in SimulatedFSDataset.java failed to remove (invalidate) blocks from the file system.
Date Sun, 07 Sep 2014 23:06:28 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14125090#comment-14125090
] 

Megasthenis Asteris commented on HDFS-6799:
-------------------------------------------

_unfinalizeBlock_ indeed needs to be fixed, but I am not sure what the expected behavior should
be. 
The way it is structured now, it seems that it would suffice to delete the block from the
SimulatedFSDataset's map of blocks. However, note that this is not exactly the opposite of
_finilizeBlock_ as one might expect.

Also, I realized that _TestSimulatedFSDataset_ also has bugs:
_checkInvalidBlock(ExtendedBlock b)_ creates a new simulated dataset every time it is called.
Clearly, b will not be in the new dataset and _checkInvalidBlock_ practically always assumes
that b is indeed an invalid block. Should I submit this as a separate bug, or fix it here?



> The invalidate method in SimulatedFSDataset.java failed to remove (invalidate) blocks
from the file system.
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-6799
>                 URL: https://issues.apache.org/jira/browse/HDFS-6799
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode, test
>    Affects Versions: 2.4.1
>            Reporter: Megasthenis Asteris
>            Assignee: Megasthenis Asteris
>            Priority: Minor
>         Attachments: HDFS-6799.patch
>
>
> The invalidate(String bpid, Block[] invalidBlks) method in SimulatedFSDataset.java should
remove all invalidBlks from the simulated file system. It currently fails to do that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message