Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D5AAA1155D for ; Thu, 28 Aug 2014 22:21:09 +0000 (UTC) Received: (qmail 21134 invoked by uid 500); 28 Aug 2014 22:21:09 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 21086 invoked by uid 500); 28 Aug 2014 22:21:09 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 21003 invoked by uid 99); 28 Aug 2014 22:21:09 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Aug 2014 22:21:09 +0000 Date: Thu, 28 Aug 2014 22:21:09 +0000 (UTC) From: "Xiaoyu Yao (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-6960) Bugfix in LazyWriter, fix test case and some refactoring MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-6960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114476#comment-14114476 ] Xiaoyu Yao commented on HDFS-6960: ---------------------------------- The change of return value from void to boolean for discardReplica() is not being used in the code. Is this necessary? > Bugfix in LazyWriter, fix test case and some refactoring > -------------------------------------------------------- > > Key: HDFS-6960 > URL: https://issues.apache.org/jira/browse/HDFS-6960 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode, test > Affects Versions: HDFS-6581 > Reporter: Arpit Agarwal > Assignee: Arpit Agarwal > Attachments: HDFS-6960.01.patch > > > LazyWriter has a bug. While saving the replica to disk we would save it under {{current/lazyPersist/}}. Instead it should be saved under the appropriate subdirectory e.g. {{current/lazyPersist/subdir1/subdir0/}}. -- This message was sent by Atlassian JIRA (v6.2#6252)