Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8EE4B11A50 for ; Tue, 26 Aug 2014 20:42:05 +0000 (UTC) Received: (qmail 79207 invoked by uid 500); 26 Aug 2014 20:42:05 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 79164 invoked by uid 500); 26 Aug 2014 20:42:05 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 79063 invoked by uid 99); 26 Aug 2014 20:42:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Aug 2014 20:42:05 +0000 Date: Tue, 26 Aug 2014 20:42:05 +0000 (UTC) From: "Hadoop QA (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-6892) Add XDR packaging method for each NFS request MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-6892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14111299#comment-14111299 ] Hadoop QA commented on HDFS-6892: --------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12664461/HDFS-6892.004.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-common-project/hadoop-nfs hadoop-hdfs-project/hadoop-hdfs-nfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7774//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7774//console This message is automatically generated. > Add XDR packaging method for each NFS request > --------------------------------------------- > > Key: HDFS-6892 > URL: https://issues.apache.org/jira/browse/HDFS-6892 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: nfs > Affects Versions: 2.2.0 > Reporter: Brandon Li > Assignee: Brandon Li > Attachments: HDFS-6892.001.patch, HDFS-6892.002.patch, HDFS-6892.003.patch, HDFS-6892.004.patch > > > This method can be used for unit tests. > Most request implements this by overriding RequestWithHandle#serialize() method. However, some request classes missed it, e.g., COMMIT3Request, MKDIR3Request,READDIR3Request, READDIRPLUS3Request, RMDIR3RequestREMOVE3Request, SETATTR3Request,SYMLINK3Request. RENAME3Reqeust is another example. -- This message was sent by Atlassian JIRA (v6.2#6252)