Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6BEF111AA5 for ; Wed, 13 Aug 2014 11:35:15 +0000 (UTC) Received: (qmail 28243 invoked by uid 500); 13 Aug 2014 11:35:15 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 28193 invoked by uid 500); 13 Aug 2014 11:35:15 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 28180 invoked by uid 99); 13 Aug 2014 11:35:15 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Aug 2014 11:35:15 +0000 Date: Wed, 13 Aug 2014 11:35:15 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-6830) BlockInfo.addStorage fails when DN changes the storage for a block replica MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095380#comment-14095380 ] Hudson commented on HDFS-6830: ------------------------------ FAILURE: Integrated in Hadoop-Yarn-trunk #644 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/644/]) HDFS-6830. BlockInfo.addStorage fails when DN changes the storage for a block replica. (Arpit Agarwal) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1617598) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfo.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeStorageInfo.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockInfo.java > BlockInfo.addStorage fails when DN changes the storage for a block replica > -------------------------------------------------------------------------- > > Key: HDFS-6830 > URL: https://issues.apache.org/jira/browse/HDFS-6830 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 2.5.0 > Reporter: Arpit Agarwal > Assignee: Arpit Agarwal > Fix For: 3.0.0, 2.6.0 > > Attachments: HDFS-6830.01.patch, HDFS-6830.02.patch, HDFS-6830.03.patch, HDFS-6830.04.patch > > > The call to {{removeStorageInfo}} is wrong because the block is still in the DatanodeStorage's list of blocks and the callee does not expect it to be. > {code} > } else { > // The block is on the DN but belongs to a different storage. > // Update our state. > removeStorage(getStorageInfo(idx)); > added = false; // Just updating storage. Return false. > } > {code} > It is a very unlikely code path to hit since storage updates usually occur via incremental block reports. -- This message was sent by Atlassian JIRA (v6.2#6252)