Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C66D711595 for ; Fri, 1 Aug 2014 00:41:39 +0000 (UTC) Received: (qmail 6358 invoked by uid 500); 1 Aug 2014 00:41:39 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 6315 invoked by uid 500); 1 Aug 2014 00:41:39 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 6299 invoked by uid 99); 1 Aug 2014 00:41:39 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Aug 2014 00:41:39 +0000 Date: Fri, 1 Aug 2014 00:41:39 +0000 (UTC) From: "Benoy Antony (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-6796) Improving the argument check during balancer command line parsing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benoy Antony updated HDFS-6796: ------------------------------- Attachment: HDFS-6796.patch Makes sense. Thanks for the review and suggestion, [~szetszwo]. I have updated the patch with individual checks for each option. > Improving the argument check during balancer command line parsing > ----------------------------------------------------------------- > > Key: HDFS-6796 > URL: https://issues.apache.org/jira/browse/HDFS-6796 > Project: Hadoop HDFS > Issue Type: Bug > Components: balancer > Affects Versions: 2.4.1 > Reporter: Benoy Antony > Assignee: Benoy Antony > Attachments: HDFS-6796.patch, HDFS-6796.patch > > > Currently balancer CLI parser simply checks if the total number of arguments is greater than 2 inside the loop. Since the check does not include any loop variables, it is not a proper check when there more than 2 arguments. -- This message was sent by Atlassian JIRA (v6.2#6252)