Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9AD3E117D7 for ; Fri, 1 Aug 2014 02:34:39 +0000 (UTC) Received: (qmail 82433 invoked by uid 500); 1 Aug 2014 02:34:39 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 82381 invoked by uid 500); 1 Aug 2014 02:34:39 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 82368 invoked by uid 99); 1 Aug 2014 02:34:39 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Aug 2014 02:34:39 +0000 Date: Fri, 1 Aug 2014 02:34:39 +0000 (UTC) From: "Yi Liu (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-6787) Remove duplicate code in FSDirectory#unprotectedConcat MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14081838#comment-14081838 ] Yi Liu commented on HDFS-6787: ------------------------------ Thank Uma, yes, I have debugged that inodes are cleaned correctly. > Remove duplicate code in FSDirectory#unprotectedConcat > ------------------------------------------------------ > > Key: HDFS-6787 > URL: https://issues.apache.org/jira/browse/HDFS-6787 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 3.0.0 > Reporter: Yi Liu > Assignee: Yi Liu > Attachments: HDFS-6787.001.patch > > > {code} > // update inodeMap > removeFromInodeMap(Arrays.asList(allSrcInodes)); > {code} > this snippet of code is duplicate, since we already have the logic above it: > {code} > for(INodeFile nodeToRemove: allSrcInodes) { > if(nodeToRemove == null) continue; > > nodeToRemove.setBlocks(null); > trgParent.removeChild(nodeToRemove, trgLatestSnapshot); > inodeMap.remove(nodeToRemove); > count++; > } > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)