Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Fri, 1 Aug 2014 07:49:38 +0000 (UTC)
From: "Yi Liu (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12730757.1406717405754.93451.1406879378815@arcas>
In-Reply-To: <JIRA.12730757.1406717405754@arcas>
References: <JIRA.12730757.1406717405754@arcas>
Subject: [jira] [Commented] (HDFS-6786) Fix potential issue of cache refresh
 interval
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082041#comment-14082041 ] 

Yi Liu commented on HDFS-6786:
------------------------------

Thanks [~andrew.wang] and [~cmccabe], let's keep as what it was.


> Fix potential issue of cache refresh interval
> ---------------------------------------------
>
>                 Key: HDFS-6786
>                 URL: https://issues.apache.org/jira/browse/HDFS-6786
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: caching
>    Affects Versions: 2.4.0
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>
> In {{CacheReplicationMonitor}}, following code is try to check whether needs to rescan every interval ms, if rescan takes n ms, then subtract n ms for the interval. But if the delta <=0, it breaks and start rescan, there will be potential issue: if user set the interval to a small value or rescan finished after a while exceeding the interval, then rescan will happen in loop. Furthermore, {{delta <= 0}} trigger the rescan should not be the intention, since if needs rescan, {{needsRescan}} will be set.
> {code}
>          while (true) {
>             if (shutdown) {
>               LOG.info("Shutting down CacheReplicationMonitor");
>               return;
>             }
>             if (needsRescan) {
>               LOG.info("Rescanning because of pending operations");
>               break;
>             }
>             long delta = (startTimeMs + intervalMs) - curTimeMs;
>             if (delta <= 0) {
>               LOG.info("Rescanning after " + (curTimeMs - startTimeMs) +
>                   " milliseconds");
>               break;
>             }
>             doRescan.await(delta, TimeUnit.MILLISECONDS);
>             curTimeMs = Time.monotonicNow();
>           }
> {code}


--
This message was sent by Atlassian JIRA
(v6.2#6252)