hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6940) Initial refactoring to allow ConsensusNode implementation
Date Tue, 26 Aug 2014 00:22:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110052#comment-14110052
] 

Aaron T. Myers commented on HDFS-6940:
--------------------------------------

As you and I have discussed before, subclassing and overriding what are really internal methods
of NN behavior is very fragile, both from the perspective of maintainers of the NameNode being
handicapped in what changes they can make, and from the perspective of inadvertently breaking
the behavior of the ConsensusNode (or any subclass) of the NN.

I'd be much more comfortable with this if the relevant NN hooks were some sort of more well-defined
interface that the ConsensusNode could implement, instead of overriding select superclass
methods.

> Initial refactoring to allow ConsensusNode implementation
> ---------------------------------------------------------
>
>                 Key: HDFS-6940
>                 URL: https://issues.apache.org/jira/browse/HDFS-6940
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: 3.0.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>         Attachments: HDFS-6940.patch
>
>
> Minor refactoring of FSNamesystem to open private methods that are needed for CNode implementation.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message