hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HDFS-6902) FileWriter should be closed in finally block in BlockReceiver#receiveBlock()
Date Thu, 21 Aug 2014 03:50:28 GMT
Ted Yu created HDFS-6902:
----------------------------

             Summary: FileWriter should be closed in finally block in BlockReceiver#receiveBlock()
                 Key: HDFS-6902
                 URL: https://issues.apache.org/jira/browse/HDFS-6902
             Project: Hadoop HDFS
          Issue Type: Bug
            Reporter: Ted Yu
            Priority: Minor


Here is code starting from line 828:
{code}
            try {
              FileWriter out = new FileWriter(restartMeta);
              // write out the current time.
              out.write(Long.toString(Time.now() + restartBudget));
              out.flush();
              out.close();
            } catch (IOException ioe) {
{code}
If write() or flush() call throws IOException, out wouldn't be closed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message