hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6848) Lack of synchronization on access to datanodeUuid in DataStorage#format()
Date Thu, 14 Aug 2014 01:54:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096431#comment-14096431
] 

Ted Yu commented on HDFS-6848:
------------------------------

bq. it is better to call the synchronized method setDatanodeUuid() 
That should be good.

> Lack of synchronization on access to datanodeUuid in DataStorage#format() 
> --------------------------------------------------------------------------
>
>                 Key: HDFS-6848
>                 URL: https://issues.apache.org/jira/browse/HDFS-6848
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}
>     this.datanodeUuid = datanodeUuid;
> {code}
> The above assignment should be done holding lock "DataStorage.this" - as is done in two
other places.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message