hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinayakumar B (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6830) BlockInfo.addStorage fails when DN updates storage
Date Fri, 08 Aug 2014 08:17:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090460#comment-14090460
] 

Vinayakumar B commented on HDFS-6830:
-------------------------------------

Arpit. Have you seen this occuring?

Codewise, changes looks good.

but, is this really happening?

IMO, this can happen only if,
1. Block is present in multiple storages of the same datanode. DN will not allow this to happen
through write flow.
2. Block is moved manually to some other storage and DN restarted.

> BlockInfo.addStorage fails when DN updates storage
> --------------------------------------------------
>
>                 Key: HDFS-6830
>                 URL: https://issues.apache.org/jira/browse/HDFS-6830
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.5.0
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>         Attachments: HDFS-6830.01.patch, HDFS-6830.02.patch, HDFS-6830.03.patch
>
>
> The call to {{removeStorageInfo}} is wrong because the block is still in the DatanodeStorage's
list of blocks and the callee does not expect it to be.
> {code}
>       } else {
>         // The block is on the DN but belongs to a different storage.
>         // Update our state.
>         removeStorage(getStorageInfo(idx));
>         added = false;      // Just updating storage. Return false.
>       }
> {code}
> It is a very unlikely code path to hit since storage updates usually occur via incremental
block reports.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message