hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-6813) WebHdfsFileSystem#OffsetUrlInputStream should implement PositionedReadable with thead-safe.
Date Mon, 04 Aug 2014 14:19:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084056#comment-14084056
] 

Uma Maheswara Rao G edited comment on HDFS-6813 at 8/4/14 2:18 PM:
-------------------------------------------------------------------

I think from PositionedReadable doc, this looks reasonable to me. But I also noticed FsInputStream
also have the APIs with out synchronized. Also the read api in DFSInputStream also not synchronized,
but not sure that was left without synchronization intentionally. 

[~szetszwo], can you please confirm if there is any reason for not synchronized and did not
follow the PositionedReadable  java doc? Thanks


was (Author: umamaheswararao):
I think from PositionedReadable doc, this looks reasonable to me. But I also noticed FsInputStream
also have the APIs with out synchronized. Also the read api in DFSInputStream also not synchronized,
but sure that was left with synchronization with intention. 

[~szetszwo], can you please confirm if there is any reason for not synchronized and did not
follow the PositionedReadable  java doc? Thanks

> WebHdfsFileSystem#OffsetUrlInputStream should implement PositionedReadable with thead-safe.
> -------------------------------------------------------------------------------------------
>
>                 Key: HDFS-6813
>                 URL: https://issues.apache.org/jira/browse/HDFS-6813
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: webhdfs
>    Affects Versions: 2.6.0
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>         Attachments: HDFS-6813.001.patch
>
>
> {{PositionedReadable}} definition requires the implementations for its interfaces should
be thread-safe.
> OffsetUrlInputStream(WebHdfsFileSystem inputstream) doesn't implement these interfaces
with tread-safe, this JIRA is to fix this.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message