hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6788) Improve synchronization in BPOfferService with read write lock
Date Fri, 01 Aug 2014 21:53:39 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083017#comment-14083017
] 

Andrew Wang commented on HDFS-6788:
-----------------------------------

As an FYI, I just did a quick revert + fix for the branch-2 version of this since the SVN
merge messed up (a brace was in the wrong place, but no conflict).

> Improve synchronization in BPOfferService with read write lock
> --------------------------------------------------------------
>
>                 Key: HDFS-6788
>                 URL: https://issues.apache.org/jira/browse/HDFS-6788
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 2.5.0
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>             Fix For: 2.6.0
>
>         Attachments: HDFS-6788.001.patch, HDFS-6788.002.patch
>
>
> Threads in DN (DataXceiver, PacketResponder, Async disk worker etc) may block at BPOfferService.getBlockPoolId()
when calling BPOfferService.checkBlock(), though they are just reading the same blockpool
id. This is unnecessary overhead and may cause performance hit when many threads compete.
Filing this jira to replace synchronized method with read write lock (ReentrantReadWriteLock).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message