hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-6788) Improve synchronization in BPOfferService with read write lock
Date Fri, 01 Aug 2014 18:57:39 GMT

     [ https://issues.apache.org/jira/browse/HDFS-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Wang updated HDFS-6788:
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.6.0
           Status: Resolved  (was: Patch Available)

Committed to trunk and branch-2, thanks for the patch Yongjun and thanks Arpit for the reviews.

> Improve synchronization in BPOfferService with read write lock
> --------------------------------------------------------------
>
>                 Key: HDFS-6788
>                 URL: https://issues.apache.org/jira/browse/HDFS-6788
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 2.5.0
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>             Fix For: 2.6.0
>
>         Attachments: HDFS-6788.001.patch, HDFS-6788.002.patch
>
>
> Threads in DN (DataXceiver, PacketResponder, Async disk worker etc) may block at BPOfferService.getBlockPoolId()
when calling BPOfferService.checkBlock(), though they are just reading the same blockpool
id. This is unnecessary overhead and may cause performance hit when many threads compete.
Filing this jira to replace synchronized method with read write lock (ReentrantReadWriteLock).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message