hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yi Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6787) Remove duplicate code in FSDirectory#unprotectedConcat
Date Fri, 01 Aug 2014 02:34:39 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14081838#comment-14081838
] 

Yi Liu commented on HDFS-6787:
------------------------------

Thank Uma, yes, I have debugged that inodes are cleaned correctly.

> Remove duplicate code in FSDirectory#unprotectedConcat
> ------------------------------------------------------
>
>                 Key: HDFS-6787
>                 URL: https://issues.apache.org/jira/browse/HDFS-6787
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 3.0.0
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>         Attachments: HDFS-6787.001.patch
>
>
> {code}
> // update inodeMap
> removeFromInodeMap(Arrays.asList(allSrcInodes));
> {code}
> this snippet of code is duplicate, since we already have the logic above it:
> {code}
>     for(INodeFile nodeToRemove: allSrcInodes) {
>       if(nodeToRemove == null) continue;
>       
>       nodeToRemove.setBlocks(null);
>       trgParent.removeChild(nodeToRemove, trgLatestSnapshot);
>       inodeMap.remove(nodeToRemove);
>       count++;
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message