Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EEC4311BB5 for ; Tue, 29 Jul 2014 13:42:38 +0000 (UTC) Received: (qmail 84852 invoked by uid 500); 29 Jul 2014 13:42:38 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 84799 invoked by uid 500); 29 Jul 2014 13:42:38 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 84787 invoked by uid 99); 29 Jul 2014 13:42:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Jul 2014 13:42:38 +0000 Date: Tue, 29 Jul 2014 13:42:38 +0000 (UTC) From: "Daryn Sharp (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-6765) Log INodeID instead of full path in edit log when closing a file MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-6765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077708#comment-14077708 ] Daryn Sharp commented on HDFS-6765: ----------------------------------- Other than the inconsistency with other edit ops, is this going to break compatibility for the edits viewer? I'm a bit leery due to recent edit log corruptions. Replaying the edit based on inode instead of path isn't replaying the edit as originally issued which may mask edit bugs. I'll look at HDFS-6757 but could you elaborate on what impact this has on performance (other than re-building the path?) and what cleanup it blocks? > Log INodeID instead of full path in edit log when closing a file > ---------------------------------------------------------------- > > Key: HDFS-6765 > URL: https://issues.apache.org/jira/browse/HDFS-6765 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Haohui Mai > > When closing a file, currently the edit log records the full path instead of the inode id. The performance is sub-optimal, and it prevents further clean ups of the code (e.g., HDFS-6757) > This jira proposes to record inode id instead of the full path in edit logs when closing a file. -- This message was sent by Atlassian JIRA (v6.2#6252)