Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 82CAE11185 for ; Tue, 22 Jul 2014 03:49:39 +0000 (UTC) Received: (qmail 74932 invoked by uid 500); 22 Jul 2014 03:49:39 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 74876 invoked by uid 500); 22 Jul 2014 03:49:39 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 74855 invoked by uid 99); 22 Jul 2014 03:49:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Jul 2014 03:49:38 +0000 Date: Tue, 22 Jul 2014 03:49:38 +0000 (UTC) From: "Yi Liu (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-6720) Remove KeyProvider in EncryptionZoneManager MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-6720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069773#comment-14069773 ] Yi Liu commented on HDFS-6720: ------------------------------ Thanks [~andrew.wang], the patch is straight and good. One comment, +1 after addressing it. {quote} // Re-get the new encryption zone add the latest key version ezi = getEncryptionZoneForPath(srcIIP); {quote} This is not necessary, please remove it. > Remove KeyProvider in EncryptionZoneManager > ------------------------------------------- > > Key: HDFS-6720 > URL: https://issues.apache.org/jira/browse/HDFS-6720 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: security > Affects Versions: fs-encryption (HADOOP-10150 and HDFS-6134) > Reporter: Yi Liu > Assignee: Andrew Wang > Priority: Minor > Attachments: hdfs-6720.001.patch > > > We don't need KeyProvider in EncryptionZoneManager any more, so we need to remove KeyProvider variable in class and KeyProvider parameter for EncryptionZoneManager#createEncryptionZone -- This message was sent by Atlassian JIRA (v6.2#6252)