Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Wed, 16 Jul 2014 19:47:07 +0000 (UTC)
From: "Andrew Wang (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12727477.1405458945745.56675.1405540027673@arcas>
In-Reply-To: <JIRA.12727477.1405458945745@arcas>
References: <JIRA.12727477.1405458945745@arcas>
Subject: [jira] [Commented] (HDFS-6690) Deduplicate xattr names in memory
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063983#comment-14063983 ] 

Andrew Wang commented on HDFS-6690:
-----------------------------------

I think throwing down FSDirectory lock asserts in this class is somewhat gross, since these are all static methods. We could pass in the FSDirectory each time to do this check, but I see XAttrStorage as a helper class where we could let this kind of check slide. I can do it though.

> Deduplicate xattr names in memory
> ---------------------------------
>
>                 Key: HDFS-6690
>                 URL: https://issues.apache.org/jira/browse/HDFS-6690
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 2.5.0
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-6690.001.patch, hdfs-6690.002.patch
>
>
> When the same string is used repeatedly for an xattr name, we could potentially save some NN memory by deduplicating the strings.


--
This message was sent by Atlassian JIRA
(v6.2#6252)