Return-Path: 
 <hdfs-issues-return-89144-apmail-hadoop-hdfs-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id B586C11547
	for <apmail-hadoop-hdfs-issues-archive@minotaur.apache.org>;
 Sat,  5 Jul 2014 17:24:34 +0000 (UTC)
Received: (qmail 72375 invoked by uid 500); 5 Jul 2014 17:24:34 -0000
Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org
Received: (qmail 72318 invoked by uid 500); 5 Jul 2014 17:24:34 -0000
Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:hdfs-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:hdfs-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:hdfs-issues@hadoop.apache.org>
List-Id: <hdfs-issues.hadoop.apache.org>
Reply-To: hdfs-issues@hadoop.apache.org
Delivered-To: mailing list hdfs-issues@hadoop.apache.org
Received: (qmail 72306 invoked by uid 99); 5 Jul 2014 17:24:34 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 Jul 2014 17:24:34 +0000
Date: Sat, 5 Jul 2014 17:24:33 +0000 (UTC)
From: "Uma Maheswara Rao G (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12725581.1404580525519.7854.1404581073974@arcas>
In-Reply-To: <JIRA.12725581.1404580525519@arcas>
References: <JIRA.12725581.1404580525519@arcas>
Subject: [jira] [Commented] (HDFS-6629) Not able to create symlinks after
 HDFS-6516
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HDFS-6629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14052927#comment-14052927 ] 

Uma Maheswara Rao G commented on HDFS-6629:
-------------------------------------------

I think, as Xattrs not supported on symlinks, we should have check on inode that if inode is not a symlink then only we should try dealing with xattrs as that inode might not have added with any crypto zone related xattr. 

{code}
 final XAttrFeature xaf = inode.getXAttrFeature();
      if (xaf != null) {
        final List<XAttr> xattrs = xaf.getXAttrs();
        for (XAttr xattr : xattrs) {
          final String xaName = XAttrHelper.getPrefixName(xattr);
          if (CRYPTO_XATTR_ENCRYPTION_ZONE.equals(xaName)) {
            encryptionZones.put(inode.getId(),
              new EncryptionZoneInt(new String(xattr.getValue()),
                                    inode.getId()));
          }
        }
      }
{code}

[~clamb], are you ok with this change? Please correct me if I did not follow it correctly.

> Not able to create symlinks after HDFS-6516
> -------------------------------------------
>
>                 Key: HDFS-6629
>                 URL: https://issues.apache.org/jira/browse/HDFS-6629
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>             Fix For: fs-encryption (HADOOP-10150 and HDFS-6134)
>
>
> {noformat}
> java.lang.UnsupportedOperationException: XAttrs are not supported on symlinks
> 	at org.apache.hadoop.hdfs.server.namenode.INodeSymlink.getXAttrFeature(INodeSymlink.java:137)
> 	at org.apache.hadoop.hdfs.server.namenode.INode.getXAttrFeature(INode.java:192)
> 	at org.apache.hadoop.hdfs.server.namenode.FSDirectory.addToInodeMap(FSDirectory.java:2233)
> 	at org.apache.hadoop.hdfs.server.namenode.FSDirectory.addChild(FSDirectory.java:2137)
> 	at org.apache.hadoop.hdfs.server.namenode.FSDirectory.addLastINode(FSDirectory.java:2080)
> 	at org.apache.hadoop.hdfs.server.namenode.FSDirectory.addINode(FSDirectory.java:1900)
> 	at org.apache.hadoop.hdfs.server.namenode.FSDirectory.unprotectedAddSymlink(FSDirectory.java:2562)
> 	at org.apache.hadoop.hdfs.server.namenode.FSDirectory.addSymlink(FSDirectory.java:2550)
> 	at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.addSymlink(FSNamesystem.java:4768)
> 	at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.createSymlinkInt(FSNamesystem.java:2193)
> 	at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.createSymlink(FSNamesystem.java:2153)
> {noformat}
> Noticed from fs-encryption jenkins.



--
This message was sent by Atlassian JIRA
(v6.2#6252)