hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6739) Add getDatanodeStorageReport to ClientProtocol
Date Mon, 28 Jul 2014 18:12:39 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076506#comment-14076506
] 

Jing Zhao commented on HDFS-6739:
---------------------------------

The patch looks good to me. Only nits:
# Looks like the changes in TestPBHelper can be avoided since they are all about the imports?
# There are two empty lines at the end of DatanodeStorageReport.
# PBHelper#convertDatanodeStorageReports exceeds the 80 characters line limit.

+1 after addressing the comments.

Besides, do we need to consider the scenario that the getDatanodeStorageReport response size
exceeds the max response size? For a large cluster looks like the response size can exceeds
1MB? Then we may need to use multiple RPC to handle the report. But this is something we can
address in a separate jira.

> Add getDatanodeStorageReport to ClientProtocol
> ----------------------------------------------
>
>                 Key: HDFS-6739
>                 URL: https://issues.apache.org/jira/browse/HDFS-6739
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client, namenode
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>         Attachments: h6739_20140724.patch
>
>
> ClientProtocol has a getDatanodeReport(..) methods for retrieving datanode report from
namenode.  However, there is no way to get datanode storage report.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message