hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yongjun Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6588) Investigating removing getTrueCause method in Server.java
Date Thu, 17 Jul 2014 00:48:06 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064426#comment-14064426

Yongjun Zhang commented on HDFS-6588:

Thanks [~cmccabe]. 

In the same comment I quoted from, I was trying to say that another test without the patch
here failed the same tests :
Similar failures were reported with another run for a different jira:
I believe the patch here is not related to symlink at all.  I will upload the same patch one
more time when HDFS-6683/HDFS-6693 is committed.

> Investigating removing getTrueCause method in Server.java
> ---------------------------------------------------------
>                 Key: HDFS-6588
>                 URL: https://issues.apache.org/jira/browse/HDFS-6588
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: security, webhdfs
>    Affects Versions: 2.5.0
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>         Attachments: HDFS-6588.001.patch, HDFS-6588.001.patch
> When addressing Daryn Sharp's comment for HDFS-6475 quoted below:
> {quote}
> What I'm saying is I think the patch adds too much unnecessary code. Filing an improvement
to delete all but a few lines of the code changed in this patch seems a bit odd. I think you
just need to:
> - Delete getTrueCause entirely instead of moving it elsewhere
> - In saslProcess, just throw the exception instead of running it through getTrueCause
since it's not a "InvalidToken wrapping another exception" anymore.
> - Keep your 3-line change to unwrap SecurityException in toResponse
> {quote}
> There are multiple test failures, after making the suggested changes, Filing this jira
to dedicate to the investigation of removing getTrueCause method.
> More detail will be put in the first comment.

This message was sent by Atlassian JIRA

View raw message