hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6451) NFS should not return NFS3ERR_IO for AccessControlException
Date Mon, 28 Jul 2014 11:24:40 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076139#comment-14076139
] 

Hadoop QA commented on HDFS-6451:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12658118/HDFS-6451.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs-nfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7474//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7474//console

This message is automatically generated.

> NFS should not return NFS3ERR_IO for AccessControlException 
> ------------------------------------------------------------
>
>                 Key: HDFS-6451
>                 URL: https://issues.apache.org/jira/browse/HDFS-6451
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: nfs
>            Reporter: Brandon Li
>         Attachments: HDFS-6451.patch
>
>
> As [~jingzhao] pointed out in HDFS-6411, we need to catch the AccessControlException
from the HDFS calls, and return NFS3ERR_PERM instead of NFS3ERR_IO for it.
> Another possible improvement is to have a single class/method for the common exception
handling process, instead of repeating the same exception handling process in different NFS
methods.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message