hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6405) Test Crypto streams in HDFS
Date Wed, 16 Jul 2014 01:52:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062986#comment-14062986

Andrew Wang commented on HDFS-6405:

Hi Yi, overall looks good, few small comments:

* writeCheck has an unused parameter {{Path file}}
* shutdown, put a space after {{if}}, feel free to just run the auto-formatter on this file
* Any reason we couldn't just fold testFileWrite into CryptoStreamsTestBase? We could do an
{{instanceof FSDataOutputStream}} check. I also see that the subclasses @Ignore out unsupported
tests, which is another option.

> Test Crypto streams in HDFS
> ---------------------------
>                 Key: HDFS-6405
>                 URL: https://issues.apache.org/jira/browse/HDFS-6405
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: fs-encryption (HADOOP-10150 and HDFS-6134)
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>             Fix For: fs-encryption (HADOOP-10150 and HDFS-6134)
>         Attachments: HDFS-6405.1.patch, HDFS-6405.2.patch, HDFS-6405.3.patch, HDFS-6405.4.patch,
> Test file write/read, syncable, positioned read, seek and others for Crypto streams.

This message was sent by Atlassian JIRA

View raw message