Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4291E10F0D for ; Tue, 3 Jun 2014 01:02:37 +0000 (UTC) Received: (qmail 26847 invoked by uid 500); 3 Jun 2014 01:02:37 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 26794 invoked by uid 500); 3 Jun 2014 01:02:37 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 26783 invoked by uid 99); 3 Jun 2014 01:02:37 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jun 2014 01:02:37 +0000 Date: Tue, 3 Jun 2014 01:02:37 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-6424) blockReport doesn't need to invalidate blocks on SBN MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-6424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14016109#comment-14016109 ] Hudson commented on HDFS-6424: ------------------------------ SUCCESS: Integrated in Hadoop-trunk-Commit #5645 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5645/]) HDFS-6424. blockReport doesn't need to invalidate blocks on SBN. Contributed by Ming Ma. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1599397) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyBlockManagement.java > blockReport doesn't need to invalidate blocks on SBN > ---------------------------------------------------- > > Key: HDFS-6424 > URL: https://issues.apache.org/jira/browse/HDFS-6424 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Ming Ma > Assignee: Ming Ma > Fix For: 2.5.0 > > Attachments: HDFS-6424-2.patch, HDFS-6424-3.patch, HDFS-6424.patch > > > After the fix in https://issues.apache.org/jira/browse/HDFS-6178, blockManager no longer compute pending replication work on SBN. As part of that, it also stop removing items from invalidateBlocks. > blocks can still be added to invalidateBlocks on SBN as part of blockReport. As a result, the PendingDeletionBlocks metrics will keep going up on SBN. > To fix that, we don't need to add blocks to invalidateBlocks during blockReport for SBN. -- This message was sent by Atlassian JIRA (v6.2#6252)