Return-Path: 
 <hdfs-issues-return-87491-apmail-hadoop-hdfs-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id DA111112F5
	for <apmail-hadoop-hdfs-issues-archive@minotaur.apache.org>;
 Sat, 14 Jun 2014 06:32:02 +0000 (UTC)
Received: (qmail 21382 invoked by uid 500); 14 Jun 2014 06:32:02 -0000
Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org
Received: (qmail 21330 invoked by uid 500); 14 Jun 2014 06:32:02 -0000
Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:hdfs-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:hdfs-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:hdfs-issues@hadoop.apache.org>
List-Id: <hdfs-issues.hadoop.apache.org>
Reply-To: hdfs-issues@hadoop.apache.org
Delivered-To: mailing list hdfs-issues@hadoop.apache.org
Received: (qmail 21319 invoked by uid 99); 14 Jun 2014 06:32:02 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Jun 2014 06:32:02 +0000
Date: Sat, 14 Jun 2014 06:32:02 +0000 (UTC)
From: "pascal oliva (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12638668.1364055302532.131748.1402727522233@arcas>
In-Reply-To: <JIRA.12638668.1364055302532@arcas>
References: <JIRA.12638668.1364055302532@arcas>
Subject: [jira] [Commented] (HDFS-4629) Using
 com.sun.org.apache.xml.internal.serialize.* in XmlEditsVisitor.java is JVM
 vendor specific. Breaks IBM JAVA
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HDFS-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031489#comment-14031489 ] 

pascal oliva commented on HDFS-4629:
------------------------------------

No, there wasn't a dependency on xerces .

With IBM JVM the build works fine without xerces dependency in the pom.xml

But by using OpenJDK
i have got the following errors :
[ERROR] /home/pascal/patchI/hadoop-common/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/XmlEditsVisitor.java:[33,31]
 error: package org.apache.xml.serialize does not exist
 [ERROR] /home/pascal/patchI/hadoop-common/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/XmlEditsVisitor.java:[55,4] error: cannot find symbol
[ERROR]   symbol:   class OutputFormat
  location: class XmlEditsVisitor

And by adding :
+ <groupId>xerces</groupId>
 + <artifactId>xercesImpl</artifactId>
 + <version>2.9.0</version>
 + </dependency>

The build passed successfully with the both JVM : IBM and OpenJDK

To test the patch, I used :
mvn compile ; mvn test -fn
There is no new functionnality delivered on that patch, so i used the existing tests.


> Using com.sun.org.apache.xml.internal.serialize.* in XmlEditsVisitor.java is JVM vendor specific. Breaks IBM JAVA
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4629
>                 URL: https://issues.apache.org/jira/browse/HDFS-4629
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: tools
>    Affects Versions: 2.0.3-alpha
>         Environment: OS:fedora and RHEL (64 bit)
> Platform: x86, POWER, and SystemZ
> JVM Vendor = IBM
>            Reporter: Amir Sanjar
>         Attachments: HDFS-4629-1.patch, HDFS-4629.patch
>
>
> Porting to a non-JVM vendor solution by replacing:
> import com.sun.org.apache.xml.internal.serialize.OutputFormat;
> import com.sun.org.apache.xml.internal.serialize.XMLSerializer;
> with 
> import org.apache.xml.serialize.OutputFormat;
> import org.apache.xml.serialize.XMLSerializer;



--
This message was sent by Atlassian JIRA
(v6.2#6252)