hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6591) while loop is executed tens of thousands of times in Hedged Read
Date Wed, 25 Jun 2014 23:29:25 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14044172#comment-14044172
] 

Akira AJISAKA commented on HDFS-6591:
-------------------------------------

Nice fix to me. In TestPread.java,
{code}
    }
    isHedgedRead = true;
  }
{code}
Would you please create {{@Before}} class and initialize variables there instead of setting
at the last of {{@Test}} class like above?

Minor nits:
1. In DFSInputStream.java:1107, 
{code}
      Future<ByteBuffer> future = null;
{code}
Now that {{future}} is not used in the else clause, would you move the declaration into the
try-catch clause?
2. There is a trailing white space in
{code}
+    CompletionService<ByteBuffer> hedgedService = 
{code}

> while loop is executed tens of thousands of times  in Hedged  Read
> ------------------------------------------------------------------
>
>                 Key: HDFS-6591
>                 URL: https://issues.apache.org/jira/browse/HDFS-6591
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: 2.4.0
>            Reporter: LiuLei
>            Assignee: Liang Xie
>         Attachments: HDFS-6591.txt, LoopTooManyTimesTestCase.patch
>
>
> I download hadoop-2.4.1-rc1 code from http://people.apache.org/~acmurthy/hadoop-2.4.1-rc1/,
 I test the  Hedged  Read. I find the while loop in hedgedFetchBlockByteRange method is executed
tens of thousands of times.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message