hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6578) add toString method to DatanodeStorage for easier debugging
Date Tue, 24 Jun 2014 11:31:27 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14041992#comment-14041992
] 

Hudson commented on HDFS-6578:
------------------------------

SUCCESS: Integrated in Hadoop-Yarn-trunk #593 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/593/])
HDFS-6578. add toString method to DatanodeStorage for easier debugging. (Contributed by Yongjun
Zhang) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1604942)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/DatanodeStorage.java


> add toString method to DatanodeStorage for easier debugging
> -----------------------------------------------------------
>
>                 Key: HDFS-6578
>                 URL: https://issues.apache.org/jira/browse/HDFS-6578
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>             Fix For: 3.0.0, 2.5.0
>
>         Attachments: HDFS-6578.001.patch, HDFS-6578.002.patch
>
>
> It seems to be nice to add a toString() method for DatanodeStorage class, so we can print
out its key info easier while doing debuging.
> Another thing is, in the end of BlockManager#processReport, there is the following message,
> {code}
>    blockLog.info("BLOCK* processReport: from storage " + storage.getStorageID()
>         + " node " + nodeID + ", blocks: " + newReport.getNumberOfBlocks()
>         + ", processing time: " + (endTime - startTime) + " msecs");
>     return !node.hasStaleStorages();
> {code}
> We could add node.hasStaleStorages() to the log, and possibly replace storage.getSorateID()
with the suggested storage.toString().
> Any comments? thanks.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message