hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6578) add toString method to DatanodeStorage etc for easier debugging
Date Sat, 21 Jun 2014 10:24:24 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039759#comment-14039759
] 

Hadoop QA commented on HDFS-6578:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12651813/HDFS-6578.001.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7199//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7199//console

This message is automatically generated.

> add toString method to DatanodeStorage etc for easier debugging
> ---------------------------------------------------------------
>
>                 Key: HDFS-6578
>                 URL: https://issues.apache.org/jira/browse/HDFS-6578
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>         Attachments: HDFS-6578.001.patch
>
>
> It seems to be nice to add a toString() method for DatanodeStorage class, so we can print
out its key info easier while doing debuging.
> Another thing is, in the end of BlockManager#processReport, there is the following message,
> {code}
>    blockLog.info("BLOCK* processReport: from storage " + storage.getStorageID()
>         + " node " + nodeID + ", blocks: " + newReport.getNumberOfBlocks()
>         + ", processing time: " + (endTime - startTime) + " msecs");
>     return !node.hasStaleStorages();
> {code}
> We could add node.hasStaleStorages() to the log, and possibly replace storage.getSorateID()
with the suggested storage.toString().
> Any comments? thanks.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message