hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Charles Lamb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6521) Improve the readability of 'hadoop fs -help'
Date Thu, 12 Jun 2014 14:55:02 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029224#comment-14029224
] 

Charles Lamb commented on HDFS-6521:
------------------------------------

Hi,

Here are a few minor comments.

It looks like a comment got cut off here:

+  // Creates a two-row table, the first row is for the command line option,
+  // the

We might as well clean up some of the wording while we're in here:

+      "Changes permissions of a file." +
+      "This works similar to shell's chmod with a few exceptions.\n" +
+      "-R: modifies the files recursively. This is the only option" +
+      " currently supported.\n" +
+      "MODE: Mode is same as mode used for chmod shell command." +
+      "Only letters recognized are 'rwxXt'. E.g. +t,a+r,g-w,+rwx,o=r\n" +
+      "OCTALMODE: Mode specifed in 3 or 4 digits. If 4 digits, the first may " +

This is similar to the shell's chmod command with a few exceptions.
MODE: Mode is the same as the shell's chmod mode. The only letters recognized are ...

s/E.g./e.g./

+      "\tThis is similar to shell's chown with a few exceptions.\n" +
+      "-R: modifies the files recursively. This is the only option " +
+      "currently supported.\n" +
+      "If only owner or group is specified then only owner or " +
+      "group is modified.\n" +

This is similar to the shell's chown command with a few exceptions.
If only the owner or group is specified, then only the owner or group is modified.

It looks like you'll need to update TestCLI.


> Improve the readability of 'hadoop fs -help'
> --------------------------------------------
>
>                 Key: HDFS-6521
>                 URL: https://issues.apache.org/jira/browse/HDFS-6521
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: tools
>    Affects Versions: 2.5.0
>            Reporter: Lei Xu
>            Assignee: Lei Xu
>            Priority: Minor
>             Fix For: 2.5.0
>
>         Attachments: HDFS-6521.000.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> 'hadoop fs -help` displays help informations with numbers of different formats. 
> This patch borrows the format used in `hdfs cacheadmin -help`: all options are formatted
by using org.apache.hadoop.tools.TableListing.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message