hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yongjun Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6502) incorrect description in distcp2 document
Date Thu, 12 Jun 2014 18:47:02 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029593#comment-14029593
] 

Yongjun Zhang commented on HDFS-6502:
-------------------------------------

Hi [~ajisakaa], thanks for following up, I found your latest version is not quite what I suggested
in last comment:

{quote}
   `-update` is used to copy files from source that don't exist at the target,
-  or have different contents. `-overwrite` overwrites target-files even if they
-  exist at the source, or have the same contents.
+  or have different contents. `-overwrite` overwrites target-files that they
+  exist at the target.
 {quote}

Basically two places to change in your patch version 3 (you can refer to my last comment):
1. change "or have different contents"  to "or differ than the target version", this two are
different in that when the contents of the two files may be the same, but -update will still
update because of blocksize difference for example.
2. change "target-files that they exist" to "target-files that exist"

Thanks.



> incorrect description in distcp2 document
> -----------------------------------------
>
>                 Key: HDFS-6502
>                 URL: https://issues.apache.org/jira/browse/HDFS-6502
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 1.2.1, 2.5.0
>            Reporter: Yongjun Zhang
>            Assignee: Akira AJISAKA
>              Labels: newbie
>         Attachments: HDFS-6502.2.patch, HDFS-6502.3.patch, HDFS-6502.patch
>
>
> In http://hadoop.apache.org/docs/r1.2.1/distcp2.html#UpdateAndOverwrite
> The first statement of the "Update and Overwrite" section says:
> {quote}
> -update is used to copy files from source that don't exist at the target, or have different
contents. -overwrite overwrites target-files even if they exist at the source, or have the
same contents.
> {quote}
> The "Command Line Options" table says :
> {quote}
>   -overwrite: Overwrite destination
>   -update: Overwrite if src size different from dst size
> {quote}
> Based on the implementation, making the following modification would be more accurate:
> The first statement of the "Update and Overwrite" section:
> {code}
> -update is used to copy files from source that don't exist at the target, or have different
contents. -overwrite overwrites target-files if they exist at the target.
> {code}
> The "Command Line Options" table:
> {code}
>   -overwrite: Overwrite destination
>   -update: Overwrite destination if source and destination have different contents
> {code}
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message