hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6480) Move waitForReady() from FSDirectory to FSNamesystem
Date Wed, 18 Jun 2014 21:28:24 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036417#comment-14036417
] 

Jing Zhao commented on HDFS-6480:
---------------------------------

The 003 patch looks pretty good to me. Two minors:
# Currently in FSNamesystem#renameTo, we call waitForLoadingFSImage right before we call FSDirectory#renameTo.
In that way, we may invoke FSDirectory.resolvePath before we can guarantee that the fsdir
has been fully loaded.
# We need to update the following comment in several places:
{code}
-      // check if we are ready to initialize replication queues
+      // check if we are imageLoaded to initialize replication queues
{code}

+1 after addressing the comments.

> Move waitForReady() from FSDirectory to FSNamesystem
> ----------------------------------------------------
>
>                 Key: HDFS-6480
>                 URL: https://issues.apache.org/jira/browse/HDFS-6480
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>         Attachments: HDFS-6480.000.patch, HDFS-6480.001.patch, HDFS-6480.002.patch, HDFS-6480.003.patch
>
>
> Currently FSDirectory implements a barrier in {{waitForReady()}} / {{setReady()}} so
that it only serve requests once the FSImage is fully loaded.
> As a part of the effort to evolve {{FSDirectory}} to a class which focuses on implementing
the data structure of the namespace, this jira proposes to move the barrier one level higher
to {{FSNamesystem}}.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message