hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3848) A Bug in recoverLeaseInternal method of FSNameSystem class
Date Mon, 16 Jun 2014 21:18:02 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14032961#comment-14032961

Hadoop QA commented on HDFS-3848:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:


    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7135//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7135//console

This message is automatically generated.

> A Bug in recoverLeaseInternal method of FSNameSystem class
> ----------------------------------------------------------
>                 Key: HDFS-3848
>                 URL: https://issues.apache.org/jira/browse/HDFS-3848
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 0.23.1
>            Reporter: Hooman Peiro Sajjad
>              Labels: patch
>         Attachments: HDFS-3848-1.patch
>   Original Estimate: 1h
>  Remaining Estimate: 1h
> This is a bug in logic of the method recoverLeaseInternal. In line 1322 it checks if
the owner of the file is trying to recreate the file. The condition of the if statement is

> (leaseFile != null && leaseFile.equals(lease)) || lease.getHolder().equals(holder)
> As it can be seen, there are two operands (conditions) connected with an "or" operator.
The first operand is straight and will be true only if the holder of the file is the new holder.
But the problem is the second operand which will be always true since the "lease" object is
the one found by the "holder" by calling "Lease lease = leaseManager.getLease(holder);" in
line 1315.
> To fix this I think the if statement only should contain the following the condition:
> (leaseFile != null && leaseFile.getHolder().equals(holder))

This message was sent by Atlassian JIRA

View raw message