Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 20 May 2014 07:07:38 +0000 (UTC)
From: "Aaron T. Myers (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12698787.1393983862676.9349.1400569658302@arcas>
In-Reply-To: <JIRA.12698787.1393983862676@arcas>
References: <JIRA.12698787.1393983862676@arcas>
Subject: [jira] [Commented] (HDFS-6056) Clean up NFS config settings
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-6056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002890#comment-14002890 ] 

Aaron T. Myers commented on HDFS-6056:
--------------------------------------

This patch looks a lot better. Two small comments:

# While we're fixing up the config property names, can we switch "hadoop.nfs.userupdate.milly" to be '.millis' instead of '.milly'? The word should not have a 'y' since it's short for 'milliseconds', I've never seen 'milly' used anywhere but here, and if you grep the code base I think you'll find that most of the config settings which are set in milliseconds use '.millis' as their suffix.
# I noticed while reviewing this patch that it looks like the above config setting isn't actually read except in tests. This is because there are two constructors in the {{IdUserGroup}} class, one which takes a {{Configuration}} object and one no-arg constructor, but the no-arg one doesn't call the other. The one which takes a {{Configuration}} is called by the tests, but the other one is the one actually used in the HDFS NFS Gateway daemon.

Thanks, Brandon.

> Clean up NFS config settings
> ----------------------------
>
>                 Key: HDFS-6056
>                 URL: https://issues.apache.org/jira/browse/HDFS-6056
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: nfs
>    Affects Versions: 2.3.0
>            Reporter: Aaron T. Myers
>            Assignee: Brandon Li
>         Attachments: HDFS-6056.001.patch, HDFS-6056.002.patch, HDFS-6056.003.patch, HDFS-6056.004.patch, HDFS-6056.005.patch, HDFS-6056.006.patch
>
>
> As discussed on HDFS-6050, there's a few opportunities to improve the config settings related to NFS. This JIRA is to implement those changes, which include: moving hdfs-nfs related properties into hadoop-hdfs-nfs project, and replacing 'nfs3' with 'nfs' in the property names.


--
This message was sent by Atlassian JIRA
(v6.2#6252)