hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-6414) xattr modification operations are based on state of latest snapshot instead of current version of inode.
Date Fri, 16 May 2014 11:08:40 GMT

     [ https://issues.apache.org/jira/browse/HDFS-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Wang updated HDFS-6414:
------------------------------

    Attachment: hdfs-6414.1.patch

Thanks for the nice find Chris, patch attached which essentially follows your suggestions.

I also found an additional issue surrounding quota handling when adding a feature not present
in the snapshot, simple fix and test for that as well.

> xattr modification operations are based on state of latest snapshot instead of current
version of inode.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-6414
>                 URL: https://issues.apache.org/jira/browse/HDFS-6414
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: HDFS XAttrs (HDFS-2006)
>            Reporter: Chris Nauroth
>            Assignee: Andrew Wang
>             Fix For: HDFS XAttrs (HDFS-2006)
>
>         Attachments: hdfs-6414.1.patch, hdfs-6414.2.patch
>
>
> {{XAttrStorage#updateINodeXAttrs}} modifies the inode's {{XAttrFeature}} based on reading
its current state.  However, the logic for reading current state is incorrect and may instead
read the state of the latest snapshot.  If xattrs have been changed after creation of that
snapshot, then subsequent xattr operations may yield incorrect results.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message