hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6402) Suppress findbugs warning for failure to override equals and hashCode in FsAclPermission.
Date Fri, 16 May 2014 11:04:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999353#comment-13999353
] 

Chris Nauroth commented on HDFS-6402:
-------------------------------------

The test failures appear to be unrelated.  I cannot repro locally.  I'm going to commit this.

> Suppress findbugs warning for failure to override equals and hashCode in FsAclPermission.
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-6402
>                 URL: https://issues.apache.org/jira/browse/HDFS-6402
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 3.0.0, 2.4.1
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Trivial
>             Fix For: 3.0.0, 2.4.1
>
>         Attachments: HDFS-6402.1.patch
>
>
> HDFS-6326 introduced the {{FsAclPermission}} class as a subclass of {{FsPermission}}.
 This triggered a findbugs warning due to not overriding {{equals}} and {{hashCode}}.  It's
intentional that these methods are not overridden.  We can override them to call {{super.equals}}
and {{super.hashCode}} to suppress the findbugs warning.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message