hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6392) Wire crypto streams for encrypted files in DFSClient
Date Fri, 30 May 2014 23:24:02 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014352#comment-14014352
] 

Andrew Wang commented on HDFS-6392:
-----------------------------------

Generally looks good, just a few comments:

- Can we add a comment about why we need the getWrappedStream change?
- Should not hardcode the buffer sizes for the streams, they automatically use the right value
from the confs
- stream key and IV getters could use quick javadoc
- Can we make the key and IV final, and avoid the need for synchronized on the getters in
DFSInputStream?
- HdfsFileStatus, we should do the update to remove usages of the old constructor. We can
just make it pass NULLs in everywhere except for FSDirectory, where we can pass in the hardcoded
values. Also need a new line before the constructor.
- HdfsLocatedFileStatus and LocatedBlocks, same comment as above, let's just go update the
constructor. Can make things final too.
- General comment, sprinkling the same hardcoding everywhere is not as nice as say, defining
it statically once somewhere, makes it easier to undo the hardcode later
- Indentation in PBHelper#convert was changed from two indents to one, but two indents is
our code style.
- Let's undo the changes in BlockManager and FSDirectory, they're just adding TODOs and whitespace
- The NameNode changes I believe are already up on another JIRA, so let's handle those there
as well

Thanks Charles.

>  Wire crypto streams for encrypted files in DFSClient
> -----------------------------------------------------
>
>                 Key: HDFS-6392
>                 URL: https://issues.apache.org/jira/browse/HDFS-6392
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode, security
>            Reporter: Alejandro Abdelnur
>            Assignee: Charles Lamb
>         Attachments: HDFS-6392.1.patch
>
>
> When the DFS client gets a key material and IV for a file being opened/created, it should
wrap the stream with a crypto stream initialized with the key material and IV.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message