hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6377) Unify xattr name and value limits into a single limit
Date Tue, 13 May 2014 22:31:22 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996988#comment-13996988
] 

Andrew Wang commented on HDFS-6377:
-----------------------------------

Hey Chris, good comments. Let's remove the import in HDFS-6395.

The cacheManager check was because of the new unit test I added for testing the Precondition
checks. Basically, if the NN fails in its constructor, it calls stopActiveServices to clean
up. Since FSDirectory can throw a precondition, this means we try to clean up while cacheManager
is still null. This meant I was getting a NullPointerException rather than the IllegalArgumentException
I wanted to verify, and I couldn't get the LogVerificationAppender to show me the stack trace.
Thus, the null check :)

> Unify xattr name and value limits into a single limit
> -----------------------------------------------------
>
>                 Key: HDFS-6377
>                 URL: https://issues.apache.org/jira/browse/HDFS-6377
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: HDFS XAttrs (HDFS-2006)
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>             Fix For: HDFS XAttrs (HDFS-2006)
>
>         Attachments: hdfs-6377-1.patch, hdfs-6377-2.patch
>
>
> Instead of having separate limits and config options for the size of an xattr's name
and value, let's use a single limit.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message