hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6351) Command "hdfs dfs -rm -r" can't remove empty directory
Date Sat, 10 May 2014 22:13:28 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993109#comment-13993109
] 

Andrew Wang commented on HDFS-6351:
-----------------------------------

This looks good to me, the patch split here helps. Only a few nits, overall +1.

* In FSPermissionChecker, I think it'd be clearer to write {{!(cList.isEmpty() &&
ignoreEmptyDir)}} since that avoids a double negative.
* Also need to add new parameter to javadoc of checkPermission

[~daryn] this is a quicky to review if you have time, otherwise I'll commit this tomorrow
if Yongjun's rev passes Jenkins.

> Command "hdfs dfs -rm -r" can't remove empty directory
> ------------------------------------------------------
>
>                 Key: HDFS-6351
>                 URL: https://issues.apache.org/jira/browse/HDFS-6351
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>         Attachments: HDFS-6351.001.patch, HDFS-6351.002.patch
>
>
> This JIRA is fo the rmr part of the issue reported in HDFS-6165.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message