hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6298) XML based End-to-End test for getfattr and setfattr commands
Date Sun, 04 May 2014 16:06:18 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989025#comment-13989025
] 

Uma Maheswara Rao G commented on HDFS-6298:
-------------------------------------------

Overall patch looks good. Along with the Andrew comments, I have few comments here.

{code}
assertTrue("Not a HDFS: "+fs.getUri(),
+               fs instanceof DistributedFileSystem);
{code}

format is off here.


XAttrCommands.java and TestXAttrCommands.java should go into common JIRA as they are from
common project. Lets file separate JIRS there and fix.

>From design doc:
{code}
 * For xattr of "user" namespace, its access permissions are 
 * defined by the file or directory permission bits. 
{code}

I would like to see the permission related test cases to cover here.


> XML based End-to-End test for getfattr and setfattr commands
> ------------------------------------------------------------
>
>                 Key: HDFS-6298
>                 URL: https://issues.apache.org/jira/browse/HDFS-6298
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client, namenode
>    Affects Versions: HDFS XAttrs (HDFS-2006)
>            Reporter: Uma Maheswara Rao G
>            Assignee: Yi Liu
>             Fix For: HDFS XAttrs (HDFS-2006)
>
>         Attachments: HDFS-6298.1.patch, HDFS-6298.patch
>
>
> This JIRA to add test cases with CLI



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message