hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chen He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6250) TestBalancerWithNodeGroup.testBalancerWithRackLocality fails
Date Wed, 14 May 2014 14:27:15 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997583#comment-13997583
] 

Chen He commented on HDFS-6250:
-------------------------------

Hi [~djp], I think it is fine for now, [~decster]'s patch can resolve most of the problems.
There is corner case that this patch may fail.
Unit test is to verify the correctness of source code. This test case wants to check whether
balancer can keep the rack-locality if there is not over-utilized nodes. This patch may report
false negative in following condition: 

If the balancer.id file is really large and make both node0 and node1 (two nodes original
in the minicluster before adding new nodes) over-utilized. The balancer will move data blocks
from rack0 to rack1. Because balancer's purpose is to get rid of over-utilized and under-utilized
nodes by moving blocks. This patch will report failure. However, the balancer is not malfunctioned.
If we bring up two new  nodes to the minicluster, one to rack0 and one to rack1, it will be
safe.   

> TestBalancerWithNodeGroup.testBalancerWithRackLocality fails
> ------------------------------------------------------------
>
>                 Key: HDFS-6250
>                 URL: https://issues.apache.org/jira/browse/HDFS-6250
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Kihwal Lee
>            Assignee: Chen He
>         Attachments: HDFS-6250-v2.patch, HDFS-6250-v3.patch, HDFS-6250.patch, test_log.txt
>
>
> It was seen in https://builds.apache.org/job/PreCommit-HDFS-Build/6669/
> {panel}
> java.lang.AssertionError: expected:<1800> but was:<1810>
> 	at org.junit.Assert.fail(Assert.java:93)
> 	at org.junit.Assert.failNotEquals(Assert.java:647)
> 	at org.junit.Assert.assertEquals(Assert.java:128)
> 	at org.junit.Assert.assertEquals(Assert.java:147)
> 	at org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup
>  .testBalancerWithRackLocality(TestBalancerWithNodeGroup.java:253)
> {panel}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message