hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6056) Clean up NFS config settings
Date Tue, 27 May 2014 21:03:02 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14010265#comment-14010265
] 

Aaron T. Myers commented on HDFS-6056:
--------------------------------------

Hey Brandon, latest patch looks pretty good to me. Two comments for you:

# Seems like we should move {{IdUserGroup#NFS_STATIC_MAPPING_FILE_KEY}} out of {{IdUserGroup}}
and put it with all the other config names.
# I still find it unfortunate that we now have some configs which just start with "nfs." and
others which start with "dfs.nfs.". From the user's perspective, there's no good reason for
this, since they'll only be using NFS to access HDFS, so I would anticipate user confusion
of which configs do and do not start with "dfs."
# I think there may be a bit of a problem with having the {{NfsConfiguration}} class in the
hadoop-hdfs-nfs project, since it is also responsible for adding the {{DeprecationDeltas}}
for NFS config settings which only exist in the hadoop-nfs (Common) project. This means that,
though no such project exists today, if there were some other project which only depended
upon the Common hadoop-nfs project, the config deprecations would not be loaded. This seems
like it might be another argument in favor of moving all of this code into the single hadoop-hdfs-nfs
project.

> Clean up NFS config settings
> ----------------------------
>
>                 Key: HDFS-6056
>                 URL: https://issues.apache.org/jira/browse/HDFS-6056
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: nfs
>    Affects Versions: 2.3.0
>            Reporter: Aaron T. Myers
>            Assignee: Brandon Li
>         Attachments: HDFS-6056.001.patch, HDFS-6056.002.patch, HDFS-6056.003.patch, HDFS-6056.004.patch,
HDFS-6056.005.patch, HDFS-6056.006.patch, HDFS-6056.007.patch, HDFS-6056.008.patch
>
>
> As discussed on HDFS-6050, there's a few opportunities to improve the config settings
related to NFS. This JIRA is to implement those changes, which include: moving hdfs-nfs related
properties into hadoop-hdfs-nfs project, and replacing 'nfs3' with 'nfs' in the property names.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message