Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D785310C13 for ; Sat, 12 Apr 2014 22:29:21 +0000 (UTC) Received: (qmail 78058 invoked by uid 500); 12 Apr 2014 22:29:18 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 78011 invoked by uid 500); 12 Apr 2014 22:29:18 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 77995 invoked by uid 99); 12 Apr 2014 22:29:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 Apr 2014 22:29:17 +0000 Date: Sat, 12 Apr 2014 22:29:17 +0000 (UTC) From: "Chris Nauroth (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-6232) OfflineEditsViewer throws a NPE on edits containing ACL modifications MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967668#comment-13967668 ] Chris Nauroth commented on HDFS-6232: ------------------------------------- [~schu], thank you for reporting the bug. [~ajisakaa], thank you for fixing it. > OfflineEditsViewer throws a NPE on edits containing ACL modifications > --------------------------------------------------------------------- > > Key: HDFS-6232 > URL: https://issues.apache.org/jira/browse/HDFS-6232 > Project: Hadoop HDFS > Issue Type: Bug > Components: tools > Affects Versions: 3.0.0, 2.4.0 > Reporter: Stephen Chu > Assignee: Akira AJISAKA > Fix For: 2.4.1 > > Attachments: HDFS-6232.2.patch, HDFS-6232.patch > > > The OfflineEditsViewer using the XML parser will through a NPE when using an edit with a SET_ACL op. > {code} > [root@hdfs-nfs current]# hdfs oev -i edits_0000000000000000001-0000000000000000007 -o fsedits.out > 14/04/10 14:14:18 ERROR offlineEditsViewer.OfflineEditsBinaryLoader: Got RuntimeException at position 505 > Encountered exception. Exiting: null > java.lang.NullPointerException > at org.apache.hadoop.hdfs.util.XMLUtils.mangleXmlString(XMLUtils.java:122) > at org.apache.hadoop.hdfs.util.XMLUtils.addSaxString(XMLUtils.java:193) > at org.apache.hadoop.hdfs.server.namenode.FSEditLogOp.appendAclEntriesToXml(FSEditLogOp.java:4085) > at org.apache.hadoop.hdfs.server.namenode.FSEditLogOp.access$3300(FSEditLogOp.java:132) > at org.apache.hadoop.hdfs.server.namenode.FSEditLogOp$SetAclOp.toXml(FSEditLogOp.java:3528) > at org.apache.hadoop.hdfs.server.namenode.FSEditLogOp.outputToXml(FSEditLogOp.java:3928) > at org.apache.hadoop.hdfs.tools.offlineEditsViewer.XmlEditsVisitor.visitOp(XmlEditsVisitor.java:116) > at org.apache.hadoop.hdfs.tools.offlineEditsViewer.OfflineEditsBinaryLoader.loadEdits(OfflineEditsBinaryLoader.java:80) > at org.apache.hadoop.hdfs.tools.offlineEditsViewer.OfflineEditsViewer.go(OfflineEditsViewer.java:142) > at org.apache.hadoop.hdfs.tools.offlineEditsViewer.OfflineEditsViewer.run(OfflineEditsViewer.java:228) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84) > at org.apache.hadoop.hdfs.tools.offlineEditsViewer.OfflineEditsViewer.main(OfflineEditsViewer.java:237) > [root@hdfs-nfs current]# > {code} > This is reproducible by setting an acl on a file and then running the OEV on the editsinprogress file. > The stats and binary parsers run OK. -- This message was sent by Atlassian JIRA (v6.2#6252)