Return-Path: 
 <hdfs-issues-return-83135-apmail-hadoop-hdfs-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id DC1311016C
	for <apmail-hadoop-hdfs-issues-archive@minotaur.apache.org>;
 Wed,  9 Apr 2014 08:30:21 +0000 (UTC)
Received: (qmail 97049 invoked by uid 500); 9 Apr 2014 08:30:20 -0000
Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org
Received: (qmail 97017 invoked by uid 500); 9 Apr 2014 08:30:18 -0000
Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:hdfs-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:hdfs-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:hdfs-issues@hadoop.apache.org>
List-Id: <hdfs-issues.hadoop.apache.org>
Reply-To: hdfs-issues@hadoop.apache.org
Delivered-To: mailing list hdfs-issues@hadoop.apache.org
Received: (qmail 97002 invoked by uid 99); 9 Apr 2014 08:30:18 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Apr 2014 08:30:18 +0000
Date: Wed, 9 Apr 2014 08:30:18 +0000 (UTC)
From: "sathish (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12707275.1396995219840.84655.1397032218215@arcas>
In-Reply-To: <JIRA.12707275.1396995219840@arcas>
References: <JIRA.12707275.1396995219840@arcas>
Subject: [jira] [Updated] (HDFS-6205) FsShell setfacl can throw
 ArrayIndexOutOfBoundsException when no perm is specified
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/HDFS-6205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

sathish updated HDFS-6205:
--------------------------

    Attachment: HDFS-6205.patch

Attaching a patch with small fix.Please review it

> FsShell setfacl can throw ArrayIndexOutOfBoundsException when no perm is specified
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-6205
>                 URL: https://issues.apache.org/jira/browse/HDFS-6205
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: 3.0.0, 2.4.0
>            Reporter: Stephen Chu
>            Assignee: sathish
>            Priority: Minor
>         Attachments: HDFS-6205.patch
>
>
> If users don't specify the perm of an acl when using the FsShell's setfacl command, a fatal internal error ArrayIndexOutOfBoundsException will be thrown.
> {code}
> [root@hdfs-nfs ~]# hdfs dfs -setfacl -m user:bob: /user/hdfs/td1
> -setfacl: Fatal internal error
> java.lang.ArrayIndexOutOfBoundsException: 2
> 	at org.apache.hadoop.fs.permission.AclEntry.parseAclEntry(AclEntry.java:285)
> 	at org.apache.hadoop.fs.permission.AclEntry.parseAclSpec(AclEntry.java:221)
> 	at org.apache.hadoop.fs.shell.AclCommands$SetfaclCommand.processOptions(AclCommands.java:260)
> 	at org.apache.hadoop.fs.shell.Command.run(Command.java:154)
> 	at org.apache.hadoop.fs.FsShell.run(FsShell.java:255)
> 	at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> 	at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
> 	at org.apache.hadoop.fs.FsShell.main(FsShell.java:308)
> [root@hdfs-nfs ~]# 
> {code}
> An improvement would be if it returned something like this:
> {code}
> [root@hdfs-nfs ~]# hdfs dfs -setfacl -m user:bob:rww /user/hdfs/td1
> -setfacl: Invalid permission in <aclSpec> : user:bob:rww
> Usage: hadoop fs [generic options] -setfacl [-R] [{-b|-k} {-m|-x <acl_spec>} <path>]|[--set <acl_spec> <path>]
> [root@hdfs-nfs ~]# 
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)