Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1D9EC10E43 for ; Mon, 7 Apr 2014 21:01:56 +0000 (UTC) Received: (qmail 58880 invoked by uid 500); 7 Apr 2014 21:01:51 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 58794 invoked by uid 500); 7 Apr 2014 21:01:49 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 58571 invoked by uid 99); 7 Apr 2014 21:01:45 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Apr 2014 21:01:45 +0000 Date: Mon, 7 Apr 2014 21:01:45 +0000 (UTC) From: "Arpit Agarwal (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-6198) DataNode rolling upgrade does not correctly identify current block pool directory and replace with trash on Windows. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-6198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962252#comment-13962252 ] Arpit Agarwal commented on HDFS-6198: ------------------------------------- +1 for the updated patch, pending Jenkins. Thanks for finding and fixing it Chris. > DataNode rolling upgrade does not correctly identify current block pool directory and replace with trash on Windows. > -------------------------------------------------------------------------------------------------------------------- > > Key: HDFS-6198 > URL: https://issues.apache.org/jira/browse/HDFS-6198 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode > Affects Versions: 3.0.0, 2.4.0 > Reporter: Chris Nauroth > Assignee: Chris Nauroth > Attachments: HDFS-6198.1.patch, HDFS-6198.2.patch > > > For rolling upgrade, the DataNode uses a regex to identify the current block pool directory and replace it with the equivalent trash directory. This regex hard-codes '/' as the file path separator, which doesn't work on Windows. -- This message was sent by Atlassian JIRA (v6.2#6252)