Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A21CE10E51 for ; Thu, 3 Apr 2014 06:57:20 +0000 (UTC) Received: (qmail 50980 invoked by uid 500); 3 Apr 2014 06:57:19 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 50921 invoked by uid 500); 3 Apr 2014 06:57:18 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 50473 invoked by uid 99); 3 Apr 2014 06:57:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Apr 2014 06:57:17 +0000 Date: Thu, 3 Apr 2014 06:57:17 +0000 (UTC) From: "Konstantin Boudnik (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-5216) NumDecomDeadDataNodes not returning correct number of dead decommissioned nodes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958581#comment-13958581 ] Konstantin Boudnik commented on HDFS-5216: ------------------------------------------ Arghh... my bad [~szetszwo], thanks for taking care of this! > NumDecomDeadDataNodes not returning correct number of dead decommissioned nodes > -------------------------------------------------------------------------------- > > Key: HDFS-5216 > URL: https://issues.apache.org/jira/browse/HDFS-5216 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 2.1.0-beta > Reporter: Trevor Lorimer > Assignee: Trevor Lorimer > Attachments: HDFS-5216.diff, HDFS-5216.diff > > > For HDFS-4860 I essentially copied the process in NamenodejspHelper.generateHealthReport(), so it would be in sync with the original dfsHealth.jsp. > However looking at this now there may be a bug? in getNumDecomDeadDataNodes(), where: > getBlockManager().getDatanodeManager().fetchDatanodes(dead, null, true); > > Where the parameter true indicates that decommissioned nodes should be removed from the list. > If the flag is true fetchDatanodes calls removeDecomNodeFromList, which will remove a node if an existing datanode does not appear in both include or exclude lists and it has been decommissioned. > If I am looking to return the Number of Dead Decommissioned Nodes, should I change the remove decommissioned nodes flag to False? i.e.: > getBlockManager().getDatanodeManager().fetchDatanodes(null, dead, false); -- This message was sent by Atlassian JIRA (v6.2#6252)